linux watcher bug fixes and general slight improvements#4
linux watcher bug fixes and general slight improvements#4whyvn wants to merge 6 commits intofreref:masterfrom
Conversation
doesnt compile but the idea is that it would be more safe to update the watch descriptors of the previous files so that we can check valid descriptors in the event loop
i think its safe not to even check if the wd is below offset, it would be much faster and if inotify is sending it than it must already be valid. ill leave this commit as the basis for an idea though
creates a bit of a bug where the wd will only be updated once another file is modified
|
are ideas for "invalid" watch descriptors although i couldn't get them to work (more information is provided in the commit paragraphs). why does inotify ignore updating future wds even if you remove a watch target :( all commits up until here have just been bug fixes (and changing also someone must verify that the macos build is fine |
|
Hi Julia, thanks for your contributions, I will take a look at this after my finals as I would also have to adjust the macos build |
|
oh dont worry about it yet. i still need to implement the actual feature of this pr and i will make the draft ready once i get home and do that! |
|
Ok, ive come to the conclusion that, although i can see a use for this idea, its too niche to warrant extending the api in such a way that makes it extremely clunky (e.g. a hypothetical also, the way it would work is not too far off with the user implementing it themselves like in #3. you still have to call also, ive changed |
whyvn
changed the title
|
Closing in favor of #5 which continues this work |
2 participants
resolves #3
if you do not wish to merge this pr the bug fixes can still be merged